---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/
---
(Updated June 22, 2015, 1:13 p.m.)
Status
--
This change has been ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/#review81646
---
Ship it!
LGTM, thanks for adding the unit tests! I have just
> On Јун 6, 2015, 10:21 пре п., David Faure wrote:
> > A test doesn't really need ki18n, it could just define its own i18n()
> > function.
> >
> > Alternatively, you can put the test in a higher level framework, like
> > frameworkintegration.
I took the first approach, by adding a fake klocal
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/
---
(Updated Јун 21, 2015, 10:47 по п.)
Review request for KDE Frameworks, Al
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/#review81259
---
A test doesn't really need ki18n, it could just define its own
> On May 21, 2015, 11:29 a.m., Matthew Dawson wrote:
> > LGTM in general, but could you please add/update a unit test to test all
> > the possible cominbations of the translation?
>
> Chusslove Illich wrote:
> That would make the test depend on the Ki18n framework, which is not
> acceptabl
> On Мај 21, 2015, 5:29 по п., Matthew Dawson wrote:
> > LGTM in general, but could you please add/update a unit test to test all
> > the possible cominbations of the translation?
That would make the test depend on the Ki18n framework, which is not acceptable
for tier 1 frameworks.
Alternativ
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/#review80698
---
LGTM in general, but could you please add/update a unit test t
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123872/
---
Review request for KDE Frameworks, Alexander Potashev and Matthew Dawson.
