Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

> On May 25, 2015, 11:09 p.m., Allen Winter wrote: > > This is incorrect. std::abs comes from cstdlib, not cmath > > please fix accordingly. I have it compiling here fine on my macbook with > > #include instead of #include Fixed with http://commits.kde.org/ki18n/f0a4b6f1564efe397d804ac4ad17

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/#review80817 --- This is incorrect. std::abs comes from cstdlib, not cmath ple

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

> On May 21, 2015, 1:31 p.m., Milian Wolff wrote: > > src/klocalizedstring.cpp, line 23 > > > > > > shouldn't this be > > > > #include > > Bhushan Shah wrote: > ah yeah. meh; didn't fix it..

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/ --- (Updated May 21, 2015, 8:19 a.m.) Status -- This change has been mar

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

> On May 21, 2015, 1:31 p.m., Milian Wolff wrote: > > src/klocalizedstring.cpp, line 23 > > > > > > shouldn't this be > > > > #include ah yeah. - Bhushan

Re: Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/#review80680 --- Ship it! Ship It! src/klocalizedstring.cpp (line 23)

Review Request 123867: Fix build on OSX clang and replace another abs with std::abs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123867/ --- Review request for KDE Frameworks and Milian Wolff. Repository: ki18n D