Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/ --- (Updated May 25, 2015, 8:23 a.m.) Status -- This change has been mar

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-19 Thread Martin Klapetek
> On May 18, 2015, 7:31 p.m., Martin Gräßlin wrote: > > src/notifybypopup.cpp, line 298 > > > > > > I fear that's now most likely no longer the same. I assume that > > QDesktopWidget::availableGeometry() is the

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-19 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/ --- (Updated May 19, 2015, 12:40 p.m.) Review request for KDE Frameworks. C

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Martin Klapetek
> On May 18, 2015, 7:31 p.m., Martin Gräßlin wrote: > > src/notifybypopup.cpp, line 298 > > > > > > I fear that's now most likely no longer the same. I assume that > > QDesktopWidget::availableGeometry() is the

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Aleix Pol Gonzalez
> On May 18, 2015, 7:31 p.m., Martin Gräßlin wrote: > > src/notifybypopup.cpp, line 298 > > > > > > I fear that's now most likely no longer the same. I assume that > > QDesktopWidget::availableGeometry() is the

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/#review80591 --- src/notifybypopup.cpp (line 292)

Re: Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/#review80588 --- src/notifybypopup.cpp (line 292)

Review Request 123838: Move from QDesktopWidget to QScreen

2015-05-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123838/ --- Review request for KDE Frameworks. Repository: knotifications Descripti