Re: Review Request 123791: Cache the theme in the integration plugin

2015-05-14 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/ --- (Updated May 14, 2015, 3:34 p.m.) Status -- This change has been mar

Re: Review Request 123791: Cache the theme in the integration plugin

2015-05-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/#review80356 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 14, 2015, 5:

Re: Review Request 123791: Cache the theme in the integration plugin

2015-05-14 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/ --- (Updated May 14, 2015, 5:03 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 123791: Cache the theme in the integration plugin

2015-05-14 Thread Aleix Pol Gonzalez
> On May 14, 2015, 3:38 p.m., Aleix Pol Gonzalez wrote: > > src/integrationplugin/ktexttohtml.cpp, line 35 > > > > > > Shouldn't this be a Q_GLOBAL_STATIC? > > Daniel Vrátil wrote: > I thought that Q_GLOBAL_S

Re: Review Request 123791: Cache the theme in the integration plugin

2015-05-14 Thread Daniel Vrátil
> On May 14, 2015, 3:38 p.m., Aleix Pol Gonzalez wrote: > > src/integrationplugin/ktexttohtml.cpp, line 35 > > > > > > Shouldn't this be a Q_GLOBAL_STATIC? I thought that Q_GLOBAL_STATIC holds a pointer to the ob

Re: Review Request 123791: Cache the theme in the integration plugin

2015-05-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/#review80345 --- src/integrationplugin/ktexttohtml.cpp (line 35)

Re: Review Request 123791: Cache the theme in the integration plugin

2015-05-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/#review80341 --- +1 - Martin Klapetek On May 14, 2015, 1:48 p.m., Daniel Vrá

Review Request 123791: Cache the theme in the integration plugin

2015-05-14 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123791/ --- Review request for KDE Frameworks. Repository: kemoticons Description -