Re: Review Request 123707: Set session manager discard command

2015-05-11 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 11, 2015, 7:52 a.m.) Status -- This change has been dis

Re: Review Request 123707: Set session manager discard command

2015-05-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/#review80198 --- isLocalFile() makes everyone think of QUrl::isLocalFile(), i.e

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 11, 2015, 4:20 a.m.) Review request for KDE Frameworks and R

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/#review80186 --- If filePath() is relative, it can't be used in a discard comma

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 10, 2015, 5:11 p.m.) Review request for KDE Frameworks and R

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 10, 2015, 4:03 p.m.) Review request for KDE Frameworks and R

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
> On May 9, 2015, 7:52 p.m., David Faure wrote: > > src/core/kconfig.h, line 368 > > > > > > I don't think this API is good to have (which is why it was never > > added). Most kconfig instances are a view over m

Re: Review Request 123707: Set session manager discard command

2015-05-10 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- (Updated May 10, 2015, 10:47 a.m.) Review request for KDE Frameworks and

Re: Review Request 123707: Set session manager discard command

2015-05-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/#review80138 --- src/core/kconfig.h (line 368)

Review Request 123707: Set session manager discard command

2015-05-09 Thread Stefan Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123707/ --- Review request for KDE Frameworks and Rex Dieter. Bugs: 346768 https: