Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-08 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/ --- (Updated May 8, 2015, 9:17 a.m.) Status -- This change has been mark

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-08 Thread Christoph Cullmann
> On May 7, 2015, 8:48 p.m., David Rosca wrote: > > Sorry, didn't know of the bug. Should I discard this rr? > > Christoph Feck wrote: > Why? What you propose here was discussed as one possible option. > > David Rosca wrote: > Yes, but from the bug discussion it seems reverting those co

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-08 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/#review80080 --- Ship it! Ship It! - Christoph Cullmann On May 7, 2015, 8:4

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-07 Thread David Rosca
> On May 7, 2015, 8:48 p.m., David Rosca wrote: > > Sorry, didn't know of the bug. Should I discard this rr? > > Christoph Feck wrote: > Why? What you propose here was discussed as one possible option. Yes, but from the bug discussion it seems reverting those commits is not something that

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-07 Thread Christoph Feck
> On May 7, 2015, 8:48 p.m., David Rosca wrote: > > Sorry, didn't know of the bug. Should I discard this rr? Why? What you propose here was discussed as one possible option. - Christoph --- This is an automatically generated e-mail. To

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-07 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/#review80059 --- Sorry, didn't know of the bug. Should I discard this rr? - Da

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-07 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/ --- (Updated May 7, 2015, 8:45 p.m.) Review request for Kate and KDE Framewor

Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-07 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/ --- Review request for KDE Frameworks. Repository: ktexteditor Description