Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

2015-05-02 Thread Lindsay Roberts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/ --- (Updated May 2, 2015, 9:04 a.m.) Status -- This change has been mark

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

2015-05-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/#review79773 --- Ship it! Ship It! - David Faure On May 1, 2015, 9:55 p.m.,

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

2015-05-01 Thread Lindsay Roberts
> On May 1, 2015, 9:24 p.m., David Faure wrote: > > The conditional comes from 50a2283112225e2db4673e41d12411e8664865fa in > > kdelibs.git where qMetaTypeId was ported to > > qMetaTypeId >. However that porting looks wrong indeed, > > KShortcut was UserType in QVariant while, from what you say

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

2015-05-01 Thread Lindsay Roberts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/ --- (Updated May 2, 2015, 12:55 a.m.) Review request for KDE Frameworks and D

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

2015-05-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/#review79764 --- The conditional comes from 50a2283112225e2db4673e41d12411e8664

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

2015-05-01 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/#review79754 --- It looks ok to. +1 Consider it a ship it if noone replies in

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

2015-04-28 Thread Lindsay Roberts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/ --- (Updated April 28, 2015, 8:43 p.m.) Review request for KDE Frameworks.

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

2015-04-27 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/#review79611 --- Could you make a testcase for this? - Mark Gaiser On apr 27

Re: Review Request 123508: Shortcuts broken when user sets secondary shortcut

2015-04-27 Thread Lindsay Roberts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123508/ --- (Updated April 27, 2015, 6:01 p.m.) Review request for KDE Frameworks.