Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-27 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123477/ --- (Updated Dub. 27, 2015, 9:44 dop.) Status -- This change has been di

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Lamarque Souza
On April 23, 2015, 1:35 p.m., Jan Grulich wrote: > > And yes, this is required as long as NetworkManager headers are included by > > NetworkManagerQt headers. > > Jan Grulich wrote: > I just found out that installing FindNetworkManager.cmake into CMake > modules is not enough, because it s

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Aleix Pol Gonzalez
On April 23, 2015, 3:35 p.m., Jan Grulich wrote: > > And yes, this is required as long as NetworkManager headers are included by > > NetworkManagerQt headers. > > Jan Grulich wrote: > I just found out that installing FindNetworkManager.cmake into CMake > modules is not enough, because it s

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Jan Grulich
On Dub. 23, 2015, 1:35 odp., Jan Grulich wrote: > > And yes, this is required as long as NetworkManager headers are included by > > NetworkManagerQt headers. > > Jan Grulich wrote: > I just found out that installing FindNetworkManager.cmake into CMake > modules is not enough, because it st

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Aleix Pol Gonzalez
On April 23, 2015, 3:35 p.m., Jan Grulich wrote: > > And yes, this is required as long as NetworkManager headers are included by > > NetworkManagerQt headers. > > Jan Grulich wrote: > I just found out that installing FindNetworkManager.cmake into CMake > modules is not enough, because it s

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Jan Grulich
> On Dub. 23, 2015, 1:35 odp., Aleix Pol Gonzalez wrote: > > KF5NetworkManagerQtConfig.cmake.in, line 4 > > > > > > nitpick. weird 1 space indentation. Already spotted. On Dub. 23, 2015, 1:35 odp., Jan Grulich w

Re: Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123477/#review79383 --- KF5NetworkManagerQtConfig.cmake.in (line 4)

Review Request 123477: Add public dependency on NetworkManager

2015-04-23 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123477/ --- Review request for KDE Frameworks, David Faure, Daniel Vrátil, and Lamarque