Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-22 Thread Nerdopolis Turfwalker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/ --- (Updated April 22, 2015, 7:27 a.m.) Status -- This change has been m

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-22 Thread Nerdopolis Turfwalker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/ --- (Updated April 22, 2015, 7:13 a.m.) Review request for KDE Frameworks.

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/#review79327 --- Ship it! Ship It! - Martin Gräßlin On April 22, 2015, 9:13

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/#review79323 --- src/kidletime.cpp (lines 222 - 223)

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-21 Thread Nerdopolis Turfwalker
> On April 20, 2015, 5:48 a.m., Martin Gräßlin wrote: > > src/kidletime.cpp, lines 193-194 > > > > > > suggestion: merge the two ifs with an &&. If isPlatformX11 is false, > > the other condition isn't checked,

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-21 Thread Nerdopolis Turfwalker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/ --- (Updated April 22, 2015, 1:18 a.m.) Review request for KDE Frameworks.

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/#review79237 --- Approach looks correct to me, but can be simplified (see below

Re: Review Request 123417: Prevent plasmashell from crashing on wayland

2015-04-18 Thread Nerdopolis Turfwalker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123417/ --- (Updated April 18, 2015, 5:19 p.m.) Review request for KDE Frameworks.