Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77880 --- Ship it! Yep (looks like you posted a followup commit rather

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/ --- (Updated March 18, 2015, 1:07 p.m.) Review request for KDE Frameworks and

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Faure
On March 18, 2015, 11:26 a.m., David Rosca wrote: > > Ah see, it's the problem with the client-side installing the XML file, > > rather than the server-side. It means any new method will initially trigger > > "not implemented" compilation error in the server. Kills extensibility. But > > not

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
On March 18, 2015, 11:26 a.m., David Rosca wrote: > > Ah see, it's the problem with the client-side installing the XML file, > > rather than the server-side. It means any new method will initially trigger > > "not implemented" compilation error in the server. Kills extensibility. But > > not

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Faure
On March 18, 2015, 11:26 a.m., David Rosca wrote: > > Ah see, it's the problem with the client-side installing the XML file, > > rather than the server-side. It means any new method will initially trigger > > "not implemented" compilation error in the server. Kills extensibility. But > > not

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
On March 18, 2015, 11:26 a.m., David Rosca wrote: > > Ah see, it's the problem with the client-side installing the XML file, > > rather than the server-side. It means any new method will initially trigger > > "not implemented" compilation error in the server. Kills extensibility. But > > not

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77675 --- src/org.kde.JobViewV3.xml

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77674 --- Bump - David Rosca On March 15, 2015, 4:56 p.m., David Rosc

Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-15 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/ --- Review request for KDE Frameworks. Repository: kjobwidgets Description