Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

2015-03-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/ --- (Updated March 17, 2015, 2:26 p.m.) Status -- This change has been d

Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

2015-03-15 Thread Jeremy Whiting
> On March 15, 2015, 2:21 a.m., Frederik Gladhorn wrote: > > Without testing anything, I think that this will break QWidget's file > > dialog when set to modal. Iirc this breaks for example the open dialogs in > > qt creator. Yeah, that's the wrong approach, though I'm not sure what the right

Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

2015-03-15 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/#review77498 --- Without testing anything, I think that this will break QWidget

Review Request 122918: revert 2ee76f0 to fix QtQuickControls

2015-03-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/ --- Review request for KDE Frameworks and Frederik Gladhorn. Bugs: 345002