Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 4, 2015, 7:18 p.m.) Status -- This change has been mar

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

> On Feb. 4, 2015, 12:59 p.m., Marco Martin wrote: > > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 115 > > > > > > i'm not sure setting the panted rect in paint changes anything. > > > > s

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

> On Feb. 4, 2015, 12:59 p.m., Marco Martin wrote: > > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 115 > > > > > > i'm not sure setting the panted rect in paint changes anything. > > > > s

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75386 --- Ship it! looks better, tough i think the setPaintRect() can s

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 11:41 p.m.) Review request for KDE Frameworks and

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 10:22 p.m.) Review request for KDE Frameworks and

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

> On Feb. 3, 2015, 8:43 p.m., David Edmundson wrote: > > Next set of bugs: > > - what about if the paintedWidth is requested before the item's source has > > first been set? > > - or if the item is currently invisible? (what should that return? I'm not > > sure what Image does) > > > > > >

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

> On Feb. 3, 2015, 8:43 p.m., David Edmundson wrote: > > Next set of bugs: > > - what about if the paintedWidth is requested before the item's source has > > first been set? > > - or if the item is currently invisible? (what should that return? I'm not > > sure what Image does) > > > > > >

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75334 --- Next set of bugs: - what about if the paintedWidth is request

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 8:33 p.m.) Review request for KDE Frameworks and P

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

> On Feb. 3, 2015, 8:28 p.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp, line 159 > > > > > > only emit if we've actually changed, otherwise every binding is going > > to be

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- (Updated Feb. 3, 2015, 8:32 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75332 --- src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h

Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative