Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Feb. 21, 2015, 8:19 p.m., Matthew Dawson wrote: > > Everything looked good, but when I tried to rerun the tests to make sure > > everything is ok the kconfig_in_global_object test I'm getting an abort > > with the same error message. Backtrace: > > ``` > > #5 0x7791b630 in qAppNa

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/ --- (Updated April 4, 2015, 11:45 a.m.) Status -- This change has been m

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Feb. 21, 2015, 3:19 p.m., Matthew Dawson wrote: > > Everything looked good, but when I tried to rerun the tests to make sure > > everything is ok the kconfig_in_global_object test I'm getting an abort > > with the same error message. Backtrace: > > ``` > > #5 0x7791b630 in qAppNa

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Feb. 21, 2015, 8:19 p.m., Matthew Dawson wrote: > > Everything looked good, but when I tried to rerun the tests to make sure > > everything is ok the kconfig_in_global_object test I'm getting an abort > > with the same error message. Backtrace: > > ``` > > #5 0x7791b630 in qAppNa

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Feb. 21, 2015, 8:19 p.m., Matthew Dawson wrote: > > Everything looked good, but when I tried to rerun the tests to make sure > > everything is ok the kconfig_in_global_object test I'm getting an abort > > with the same error message. Backtrace: > > ``` > > #5 0x7791b630 in qAppNa

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/#review76407 --- Everything looked good, but when I tried to rerun the tests to

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/ --- (Updated Feb. 21, 2015, 7:58 p.m.) Review request for KDE Frameworks and

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Jan. 27, 2015, 8:55 p.m., Matthew Dawson wrote: > > Unforunately, this cause test system failures in the the > > kconfigskeletontest test suite. I'm not sure why this should create issues > > there. > > > > However, I have a partial solution that avoids creating a full > > KSharedConfig

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Jan. 27, 2015, 3:55 p.m., Matthew Dawson wrote: > > Unforunately, this cause test system failures in the the > > kconfigskeletontest test suite. I'm not sure why this should create issues > > there. > > > > However, I have a partial solution that avoids creating a full > > KSharedConfig

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Jan. 27, 2015, 8:55 p.m., Matthew Dawson wrote: > > Unforunately, this cause test system failures in the the > > kconfigskeletontest test suite. I'm not sure why this should create issues > > there. > > > > However, I have a partial solution that avoids creating a full > > KSharedConfig

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/#review74858 --- Unforunately, this cause test system failures in the the kconf

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/ --- (Updated Jan. 27, 2015, 8:10 a.m.) Review request for KDE Frameworks and

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Jan. 27, 2015, 6:31 a.m., Matthew Dawson wrote: > > Sorry, I just discovered an issue with this change as is. If the global > > object is created before KConfig's Global object, a seg fault develops. In > > this case, KConfig's global is created first avoiding the pain. However, > > co

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Jan. 27, 2015, 6:31 a.m., Matthew Dawson wrote: > > Sorry, I just discovered an issue with this change as is. If the global > > object is created before KConfig's Global object, a seg fault develops. In > > this case, KConfig's global is created first avoiding the pain. However, > > co

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/#review74802 --- Sorry, I just discovered an issue with this change as is. If

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/ --- (Updated Jan. 26, 2015, 8:11 a.m.) Review request for KDE Frameworks and

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Jan. 24, 2015, 5:12 p.m., Matthew Dawson wrote: > > src/core/kconfig.cpp, line 542 > > > > > > Reading the Qt documentation, I think its possible that appArgs[0] > > isn't the application name on Windows, a

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Jan. 24, 2015, 12:12 p.m., Matthew Dawson wrote: > > autotests/kconfig_in_global_object.cpp, line 56 > > > > > > This doesn't actually trigger anything when run without the fix below. > > Since a name is pr

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

> On Jan. 24, 2015, 5:12 p.m., Matthew Dawson wrote: > > autotests/kconfig_in_global_object.cpp, line 56 > > > > > > This doesn't actually trigger anything when run without the fix below. > > Since a name is pro

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/#review74671 --- The overall idea is sound. Just a few issues: autotests/kco

Re: Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/#review74666 --- Makes sense to me, need someone else to approve though, not a

Review Request 122232: KConfig: fix using KSharedConfig in global object destructor.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122232/ --- Review request for KDE Frameworks, Albert Astals Cid and Matthew Dawson.