Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/ --- (Updated Jan. 13, 2015, 12:49 a.m.) Status -- This change has been d

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-12 Thread Aleix Pol Gonzalez
> On Jan. 10, 2015, 4:05 p.m., Albert Astals Cid wrote: > > Can't those people that don't want their toolbars to be hidable just not > > pass ToolBar to setupGUI/createGUI ? Right, that works too... ^^' I think I'll just discard the review and slowly fade away... - Aleix --

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-10 Thread Martin Klapetek
> On Jan. 10, 2015, 5:05 p.m., Albert Astals Cid wrote: > > src/ktoolbar.h, line 217 > > > > > > Hidable sounds weird. Anyhow it's KToolbar, so i think having toolBar > > there is extra, what about isHidable? I

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/#review73670 --- Can't those people that don't want their toolbars to be hidabl

Re: Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/ --- (Updated Jan. 9, 2015, 4:27 p.m.) Review request for KDE Frameworks. Ch

Review Request 121952: Make it possible to prevent a toolbar from being hidden

2015-01-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/ --- Review request for KDE Frameworks. Bugs: 326713 https://bugs.kde.org/