Re: Review Request 121927: Update XCursor settings

2015-01-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 1:29 p.m.) Status -- This change has been mar

Re: Review Request 121927: Update XCursor settings

2015-01-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73585 --- Ship it! OK I guess this is better for future extensibility.

Re: Review Request 121927: Update XCursor settings

2015-01-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 1:24 p.m.) Review request for KDE Frameworks, Àlex

Re: Review Request 121927: Update XCursor settings

2015-01-09 Thread Martin Gräßlin
> On Jan. 9, 2015, 12:37 p.m., Àlex Fiestas wrote: > > There is test for this code in kdeplatformtheme_unittest.cpp, do you think > > it will be possible to test the fallback we have for then the size is -1? > > > > Alsot, maybe checking with XCursorGetTheme that the theme has been applied > >

Re: Review Request 121927: Update XCursor settings

2015-01-09 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73571 --- src/platformtheme/khintssettings.cpp

Re: Review Request 121927: Update XCursor settings

2015-01-09 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73570 --- Ship it! There is test for this code in kdeplatformtheme_unit

Re: Review Request 121927: Update XCursor settings

2015-01-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73568 --- Ship it! Hmm. OK. At least all the logic is in the same file

Re: Review Request 121927: Update XCursor settings

2015-01-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- (Updated Jan. 9, 2015, 10:18 a.m.) Review request for KDE Frameworks, Àle

Re: Review Request 121927: Update XCursor settings

2015-01-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/#review73559 --- autotests/CMakeLists.txt

Review Request 121927: Update XCursor settings

2015-01-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121927/ --- Review request for KDE Frameworks, Àlex Fiestas and Eike Hein. Repository