Re: Review Request 121907: Small code review

2015-01-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121907/ --- (Updated Jan. 8, 2015, 11:51 a.m.) Status -- This change has been ma

Re: Review Request 121907: Small code review

2015-01-08 Thread Aleix Pol Gonzalez
> On Jan. 8, 2015, 8:29 a.m., Albert Astals Cid wrote: > > src/platformtheme/khintssettings.h, line 62 > > > > > > Make this one const too? Yes thanks! - Aleix

Re: Review Request 121907: Small code review

2015-01-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121907/#review73461 --- src/platformtheme/khintssettings.h

Re: Review Request 121907: Small code review

2015-01-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121907/#review73451 --- Ship it! Ship It! - David Faure On Jan. 8, 2015, 2:08 a.m.

Review Request 121907: Small code review

2015-01-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121907/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des