Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-24 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Jan. 24, 2015, 1:27 nachm.) Status -- This change has been

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review74272 --- So, I took your latest upload as a basis and wrote: https://g

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review74164 --- Ralf, Can you update the diff rather than uploading the file?

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Jeremy Whiting
> On Dec. 12, 2014, 7:08 a.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn wou

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Ralf Habacker
> On Dez. 12, 2014, 3:08 nachm., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn w

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-16 Thread Ralf Habacker
> On Dez. 12, 2014, 3:08 nachm., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn w

Re: Review Request 121448: Introduce ECMAddAppIcon.

2015-01-15 Thread Jeremy Whiting
> On Dec. 12, 2014, 7:08 a.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn wou

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-19 Thread Alex Merry
> On Dec. 12, 2014, 2:08 p.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn wou

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-18 Thread Ralf Habacker
> On Dez. 12, 2014, 3:08 nachm., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn w

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-15 Thread Alex Merry
> On Dec. 12, 2014, 2:08 p.m., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn wou

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-15 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Dez. 15, 2014, 9:01 vorm.) Review request for Extra Cmake Module

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-14 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Dez. 15, 2014, 8:48 vorm.) Review request for Extra Cmake Module

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-14 Thread Ralf Habacker
> On Dez. 12, 2014, 3:08 nachm., Alex Merry wrote: > > modules/ECMAddAppIcon.cmake, line 15 > > > > > > Would this actually work? The code looks to me like pattern_rx would > > just be the filename again, so fn w

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-12 Thread Nicolás Alvarez
On Dic. 11, 2014, 1:02 p.m., Ralf Habacker wrote: > > Regarding patterns, why not just using a list of the icons we need? > > patterns+cmake have weird effects... > > Would it be possible to include a test? It's reasonably easy to create ecm > > tests nowadays and very useful afterwards. You'll

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review71863 --- The assumptions this funciton makes about the form of the argu

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-12 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Dez. 12, 2014, 2:34 nachm.) Review request for Extra Cmake Modul

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-12 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review71859 --- modules/ECMAddAppIcon.cmake

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-12 Thread Ralf Habacker
> On Dez. 11, 2014, 5:02 nachm., Aleix Pol Gonzalez wrote: > > modules/ECMAddAppIcon.cmake, line 36 > > > > > > I wouldn't take WINCE into account, its support hasn't been ported into > > kf5. > > > > Al

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/#review71815 --- modules/ECMAddAppIcon.cmake

Re: Review Request 121448: Introduce ECMAddAppIcon.

2014-12-11 Thread Ralf Habacker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121448/ --- (Updated Dez. 11, 2014, 4:40 nachm.) Review request for Extra Cmake Modul