Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-09 Thread Gun Chleoc
> On Dec. 8, 2014, 8:40 p.m., Albert Astals Cid wrote: > > I don't think this makes sense at a framework level. If some application is > > so special that really needs a special case, they can call setText over the > > kaction themselves, otherwise we're going to end up havin 20 different "Add

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-08 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121372/ --- (Updated Dec. 8, 2014, 11:41 p.m.) Status -- This change has been di

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-08 Thread Matthew Dawson
> On Dec. 8, 2014, 3:40 p.m., Albert Astals Cid wrote: > > I don't think this makes sense at a framework level. If some application is > > so special that really needs a special case, they can call setText over the > > kaction themselves, otherwise we're going to end up havin 20 different "Add

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-08 Thread Albert Astals Cid
> On des. 8, 2014, 8:40 p.m., Albert Astals Cid wrote: > > I don't think this makes sense at a framework level. If some application is > > so special that really needs a special case, they can call setText over the > > kaction themselves, otherwise we're going to end up havin 20 different "Add

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-08 Thread Gun Chleoc
> On Dec. 8, 2014, 8:40 p.m., Albert Astals Cid wrote: > > I don't think this makes sense at a framework level. If some application is > > so special that really needs a special case, they can call setText over the > > kaction themselves, otherwise we're going to end up havin 20 different "Add

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121372/#review71585 --- I don't think this makes sense at a framework level. If some a

Re: Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-06 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121372/ --- (Updated Dec. 6, 2014, 3:49 p.m.) Review request for KDE Frameworks, Loca

Review Request 121372: Differeniate between bookmarks for documents and the web

2014-12-06 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121372/ --- Review request for KDE Frameworks, Localization and Translation (l10n) and