Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- (Updated des. 8, 2014, 10:39 p.m.) Status -- This change has been di

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread Martin Klapetek
> On Dec. 5, 2014, 11:59 a.m., Martin Klapetek wrote: > > For frameworks version it's actually using notifybyaudio plugin for playing > > the sounds and that's using phonon exclusively, there's no more volume > > fiddling in fact. The notifybysound should just be removed > > altogether..don't

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread David Edmundson
> On Dec. 5, 2014, 10:59 a.m., Martin Klapetek wrote: > > For frameworks version it's actually using notifybyaudio plugin for playing > > the sounds and that's using phonon exclusively, there's no more volume > > fiddling in fact. The notifybysound should just be removed > > altogether..don't

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread Martin Klapetek
> On Dec. 5, 2014, 11:59 a.m., Martin Klapetek wrote: > > For frameworks version it's actually using notifybyaudio plugin for playing > > the sounds and that's using phonon exclusively, there's no more volume > > fiddling in fact. The notifybysound should just be removed > > altogether..don't

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread David Edmundson
> On Dec. 5, 2014, 10:59 a.m., Martin Klapetek wrote: > > For frameworks version it's actually using notifybyaudio plugin for playing > > the sounds and that's using phonon exclusively, there's no more volume > > fiddling in fact. The notifybysound should just be removed > > altogether..don't

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-05 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71411 --- For frameworks version it's actually using notifybyaudio plugi

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71379 --- Ship it! Ship It! - David Edmundson On Dec. 4, 2014, 9:12

Re: Review Request 121356: Do not change the volume when playing a notification

2014-12-04 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/#review71372 --- Ship it! Ship It! - Jeremy Whiting On Dec. 4, 2014, 2:12 p

Review Request 121356: Do not change the volume when playing a notification

2014-12-04 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121356/ --- Review request for KDE Frameworks and David Edmundson. Repository: knotif