Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/ --- (Updated Nov. 7, 2014, 2:15 p.m.) Status -- This change has been mar

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Milian Wolff
> On Nov. 7, 2014, 12:19 p.m., David Faure wrote: > > Thank you very much for looking into this. I talked to Lukas Tinkl about it > > when we met, though, and IIRC he said that it couldn't be fixed that simply > > (because of the dbus signal magic)? I'm not sure though. Did you check that > >

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/ --- (Updated Nov. 7, 2014, 2:13 p.m.) Review request for KDE Frameworks, Àlex

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Lukáš Tinkl
> On Lis. 7, 2014, 1:19 odp., David Faure wrote: > > Thank you very much for looking into this. I talked to Lukas Tinkl about it > > when we met, though, and IIRC he said that it couldn't be fixed that simply > > (because of the dbus signal magic)? I'm not sure though. Did you check that > > i

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Milian Wolff
> On Nov. 7, 2014, 12:19 p.m., David Faure wrote: > > Thank you very much for looking into this. I talked to Lukas Tinkl about it > > when we met, though, and IIRC he said that it couldn't be fixed that simply > > (because of the dbus signal magic)? I'm not sure though. Did you check that > >

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Milian Wolff
> On Nov. 7, 2014, 12:19 p.m., David Faure wrote: > > Thank you very much for looking into this. I talked to Lukas Tinkl about it > > when we met, though, and IIRC he said that it couldn't be fixed that simply > > (because of the dbus signal magic)? I'm not sure though. Did you check that > >

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69990 --- This makes me so happy I want to hug you. - Aleix Pol Gonzale

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/ --- (Updated Nov. 7, 2014, 1:33 p.m.) Review request for KDE Frameworks, Àlex

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69984 --- Ship it! Ship It! - Lukáš Tinkl On Lis. 7, 2014, 1:20 odp.

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/ --- (Updated Nov. 7, 2014, 12:20 p.m.) Review request for KDE Frameworks, Àle

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69983 --- Thank you very much for looking into this. I talked to Lukas T

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-07 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/ --- (Updated Nov. 7, 2014, 10:23 a.m.) Review request for KDE Frameworks, Àle

Re: Review Request 121007: Fix warning when using newer upower backend.

2014-11-06 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69967 --- Ship it! Finally! - Kevin Funk On Nov. 6, 2014, 1:05 a.m.,

Review Request 121007: Fix warning when using newer upower backend.

2014-11-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/ --- Review request for KDE Frameworks. Repository: solid Description --