Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Okt. 15, 2014, 11:38 nachm.) Status -- This change has been

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/#review68522 --- Ship it! You're right that the comment, which I wrote, meant

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Oct. 15, 2014, 11:08 p.m.) Review request for KDE Frameworks and

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
> On Oct. 15, 2014, 10:47 p.m., David Faure wrote: > > You're right that fromUserInput is wrong for relative paths (that should > > stay relative). fromUserInput turns them to http. > > > > However as the comment says, docPath could be either relative or absolute > > (at least both worked in K

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/#review68515 --- You're right that fromUserInput is wrong for relative paths (t

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Okt. 15, 2014, 1:09 nachm.) Review request for KDE Frameworks an

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Okt. 15, 2014, 1:08 nachm.) Review request for KDE Frameworks an

Re: Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- (Updated Oct. 15, 2014, 10:42 a.m.) Review request for KDE Frameworks and

Review Request 120595: Build correct QUrl path when KHelpClient::invokeHelp is called

2014-10-15 Thread Simon Wächter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120595/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti