Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/ --- (Updated Oct. 14, 2014, 7:47 p.m.) Status -- This change has been ma

Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/#review68414 --- Ship it! This is technically source incompatible, but only fo

Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/ --- (Updated Oct. 14, 2014, 10:11 a.m.) Review request for KDE Frameworks, Da

Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/#review68341 --- I think it's not allowed (though better ask Kevin or David) in

Review Request 120574: Add explicit to ctors with one parameter

2014-10-13 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu