Re: Review Request 120535: attica: Add const to getter methods.

2014-10-09 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/ --- (Updated Oct. 9, 2014, 7:54 p.m.) Status -- This change has been mar

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/#review68181 --- Ship it! I am pretty sure this is fine. - Albert Astals Cid

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-09 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/ --- (Updated Oct. 9, 2014, 12:02 p.m.) Review request for KDE Frameworks and

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-09 Thread Sebastian Kügler
> On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote: > > According to > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ > > "changing the const/volatile qualifiers of the function" is BIC > > > > Now the thing is if we allow BIC changes in frameworks like attica or n

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
> On Oct. 8, 2014, 3:22 p.m., Albert Astals Cid wrote: > > According to > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ > > "changing the const/volatile qualifiers of the function" is BIC > > > > Now the thing is if we allow BIC changes in frameworks like attica or n

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Aleix Pol Gonzalez
> On Oct. 8, 2014, 9:22 p.m., Albert Astals Cid wrote: > > According to > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ > > "changing the const/volatile qualifiers of the function" is BIC > > > > Now the thing is if we allow BIC changes in frameworks like attica or n

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
> On Oct. 8, 2014, 3:22 p.m., Albert Astals Cid wrote: > > According to > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ > > "changing the const/volatile qualifiers of the function" is BIC > > > > Now the thing is if we allow BIC changes in frameworks like attica or n

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/#review68095 --- According to https://techbase.kde.org/Policies/Binary_Compati

Re: Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/ --- (Updated Oct. 8, 2014, 3:20 p.m.) Review request for KDE Frameworks, kdel

Review Request 120535: attica: Add const to getter methods.

2014-10-08 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/ --- Review request for KDE Frameworks and Frederik Gladhorn. Repository: atti