Re: Review Request 120243: Remove fallback QSystemTray support

2014-10-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120243/ --- (Updated Oct. 2, 2014, 2:25 p.m.) Status -- This change has been dis

Re: Review Request 120243: Remove fallback QSystemTray support

2014-10-01 Thread David Edmundson
> On Sept. 17, 2014, 12:55 p.m., Aleix Pol Gonzalez wrote: > > Maybe we want to ifdef it? We won't require Qt 5.4 in a while... > > David Edmundson wrote: > It doesn't require Qt5.4. > > Martin Gräßlin wrote: > +1 for removing the fallback. > > Luigi Toscano wrote: > I guess the if

Re: Review Request 120243: Remove fallback QSystemTray support

2014-09-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120243/#review67057 --- does that affect Windows and MacOS? If yes I turn my +1 to -1

Re: Review Request 120243: Remove fallback QSystemTray support

2014-09-17 Thread Martin Gräßlin
> On Sept. 17, 2014, 2:55 p.m., Aleix Pol Gonzalez wrote: > > Maybe we want to ifdef it? We won't require Qt 5.4 in a while... > > David Edmundson wrote: > It doesn't require Qt5.4. > > Martin Gräßlin wrote: > +1 for removing the fallback. > > Luigi Toscano wrote: > I guess the ifd

Re: Review Request 120243: Remove fallback QSystemTray support

2014-09-17 Thread Luigi Toscano
> On Set. 17, 2014, 2:55 p.m., Aleix Pol Gonzalez wrote: > > Maybe we want to ifdef it? We won't require Qt 5.4 in a while... > > David Edmundson wrote: > It doesn't require Qt5.4. > > Martin Gräßlin wrote: > +1 for removing the fallback. > > Luigi Toscano wrote: > I guess the ifde

Re: Review Request 120243: Remove fallback QSystemTray support

2014-09-17 Thread Martin Gräßlin
> On Sept. 17, 2014, 2:55 p.m., Aleix Pol Gonzalez wrote: > > Maybe we want to ifdef it? We won't require Qt 5.4 in a while... > > David Edmundson wrote: > It doesn't require Qt5.4. > > Martin Gräßlin wrote: > +1 for removing the fallback. > > Luigi Toscano wrote: > I guess the ifd

Re: Review Request 120243: Remove fallback QSystemTray support

2014-09-17 Thread Luigi Toscano
> On Sept. 17, 2014, 2:55 p.m., Aleix Pol Gonzalez wrote: > > Maybe we want to ifdef it? We won't require Qt 5.4 in a while... > > David Edmundson wrote: > It doesn't require Qt5.4. > > Martin Gräßlin wrote: > +1 for removing the fallback. I guess the ifdef part was about keeping the s

Re: Review Request 120243: Remove fallback QSystemTray support

2014-09-17 Thread Martin Gräßlin
> On Sept. 17, 2014, 2:55 p.m., Aleix Pol Gonzalez wrote: > > Maybe we want to ifdef it? We won't require Qt 5.4 in a while... > > David Edmundson wrote: > It doesn't require Qt5.4. +1 for removing the fallback. - Martin --- This i

Re: Review Request 120243: Remove fallback QSystemTray support

2014-09-17 Thread David Edmundson
> On Sept. 17, 2014, 12:55 p.m., Aleix Pol Gonzalez wrote: > > Maybe we want to ifdef it? We won't require Qt 5.4 in a while... It doesn't require Qt5.4. - David --- This is an automatically generated e-mail. To reply, visit: https://gi

Re: Review Request 120243: Remove fallback QSystemTray support

2014-09-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120243/#review66738 --- Maybe we want to ifdef it? We won't require Qt 5.4 in a while.

Review Request 120243: Remove fallback QSystemTray support

2014-09-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120243/ --- Review request for KDE Frameworks. Repository: knotifications Descripti