Re: Review Request 120213: Add support for protocols to NETWinInfo

2014-09-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/ --- (Updated Sept. 16, 2014, 8:20 a.m.) Status -- This change has been m

Re: Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/#review66633 --- Ship it! Ship It! - Thomas Lübking On Sept. 16, 2014, 5:55

Re: Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Thomas Lübking
> On Sept. 15, 2014, 8:34 nachm., Thomas Lübking wrote: > > src/netwm.cpp, line 4630 > > > > > > Tarzan speech. Consider: > > - TakeFocusProtocol > > - Protocol::TakeFocus > > Martin Gräßlin wrote: >

Re: Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/ --- (Updated Sept. 16, 2014, 7:55 a.m.) Review request for KDE Frameworks.

Re: Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Martin Gräßlin
> On Sept. 15, 2014, 10:34 p.m., Thomas Lübking wrote: > > Minor notes only. > > > > However, I assume you also want to add protocol invocation (like exists for > > pinging the window) and therefore a preemtive warning: > > I'll *strongly* veto exposing the sync protocol to random clients (sinc

Re: Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/#review66605 --- Ship it! Minor notes only. However, I assume you also want t

Review Request 120213: Add support for protocols to NETWinInfo

2014-09-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120213/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem D