Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 7:11 p.m.) Status -- This change has been m

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66594 --- Ship it! Ship It! - Alex Merry On Sept. 15, 2014, 6:56 p.m

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:56 p.m.) Review request for KDE Frameworks and

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66593 --- Yep, I think the name change is sensible. find-modules/FindL

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
> On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't it be called FindLibGit2? > > > > Git2 and LibGit2 seem different things to me. > > Christoph Cullmann wrote: > I can rename it, but then it is inconsistent with most other > FindXXX.cmake's, as they skip the lib prefi

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- (Updated Sept. 15, 2014, 6:30 p.m.) Review request for KDE Frameworks and

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Aleix Pol Gonzalez
> On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't it be called FindLibGit2? > > > > Git2 and LibGit2 seem different things to me. > > Christoph Cullmann wrote: > I can rename it, but then it is inconsistent with most other > FindXXX.cmake's, as they skip the lib prefi

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
> On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't it be called FindLibGit2? > > > > Git2 and LibGit2 seem different things to me. > > Christoph Cullmann wrote: > I can rename it, but then it is inconsistent with most other > FindXXX.cmake's, as they skip the lib prefi

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
> On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't it be called FindLibGit2? > > > > Git2 and LibGit2 seem different things to me. > > Christoph Cullmann wrote: > I can rename it, but then it is inconsistent with most other > FindXXX.cmake's, as they skip the lib prefi

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Aleix Pol Gonzalez
> On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't it be called FindLibGit2? > > > > Git2 and LibGit2 seem different things to me. > > Christoph Cullmann wrote: > I can rename it, but then it is inconsistent with most other > FindXXX.cmake's, as they skip the lib prefi

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
> On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: > > Shouldn't it be called FindLibGit2? > > > > Git2 and LibGit2 seem different things to me. I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix. - Christoph ---

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem dif

Review Request 120196: Find-Module to detect libgit2

2014-09-14 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/ --- Review request for KDE Frameworks and Alex Merry. Repository: extra-cmake