Re: Review Request 120186: Make the encoding prober data tables const.

2014-09-13 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120186/ --- (Updated Sept. 13, 2014, 4:52 p.m.) Status -- This change has been m

Re: Review Request 120186: Make the encoding prober data tables const.

2014-09-13 Thread Volker Krause
> On Sept. 13, 2014, 4:20 p.m., Milian Wolff wrote: > > Cool, looks like a no-brained to me. Could we also wrap these things in > > anonymous namespaces to give them file-local linkage? Right, there's still 9256 bytes in .data.rel.ro, at least half of which we can probably get to .rodata as we

Re: Review Request 120186: Make the encoding prober data tables const.

2014-09-13 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120186/#review66415 --- Ship it! Cool, looks like a no-brained to me. Could we also w

Review Request 120186: Make the encoding prober data tables const.

2014-09-13 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120186/ --- Review request for KDE Frameworks. Repository: kcodecs Description