Re: Review Request 120096: replace static arrays with dynamic size with QVector

2017-02-04 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/ --- (Updated Feb. 4, 2017, 11:52 a.m.) Status -- This change has been di

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66153 --- src/k7zip.cpp

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66124 --- Ship it! Ship It! - David Faure On Sept. 9, 2014, 10:19 a.

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/ --- (Updated Sept. 9, 2014, 10:19 a.m.) Review request for KDE Frameworks and

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66110 --- Ship it! looks good from my side, but david should have a loo

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Patrick Spendrin
> On Sept. 8, 2014, 11:24 vorm., Milian Wolff wrote: > > src/k7zip.cpp, line 1509 > > > > > > this could be a QByteArray directly, and again resize it, not reserve. Should I also move the encodedBuffer out of t

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/ --- (Updated Sept. 9, 2014, 9:14 vorm.) Review request for KDE Frameworks.

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-08 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66046 --- src/k7zip.cpp

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-07 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66006 --- I would suggest to use QVarLengthArray instead. - Christoph F

Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-07 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/ --- Review request for KDE Frameworks and kdewin. Repository: karchive Desc