Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Sept. 3, 2014, 12:38 p.m.) Status -- This change has been m

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65740 --- Ship it! Ship It! - Alex Merry On Sept. 1, 2014, 10:24 a.m

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65702 --- Ship it! I think it looks good, let's get this in. - Aleix P

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Sept. 1, 2014, 3:54 p.m.) Review request for Build System and KD

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote: > > modules/ECMQueryQmake.cmake, line 2 > > > > > > CMake macros/functions that take a variable name usually take it first. > > Swapping the argument order would ma

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 27, 2014, 11:35 p.m., Alex Merry wrote: > > modules/ECMQueryQmake.cmake, line 2 > > > > > > CMake macros/functions that take a variable name usually take it first. > > Swapping the argument order would m

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote: > > modules/ECMQueryQmake.cmake, line 1 > > > > > > I think we need to be a bit more clever here. I'd go for a cache > > variable, and if (TARGET Qt5::qmake), set t

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65382 --- Nice! See my comments below, though. kde-modules/KDEInstallD

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Aug. 27, 2014, 6:41 p.m.) Review request for Build System and KD

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65255 --- kde-modules/KDEInstallDirs.cmake

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65242 --- Ship it! LOL just when the naming started to make sense, you

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 25, 2014, 10:32 p.m., David Faure wrote: > > kde-modules/KDEInstallDirs.cmake, line 340 > > > > > > I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what > > it's about. > > > >

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Aug. 25, 2014, 11:23 p.m.) Review request for Build System and K

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Aug. 25, 2014, 11:30 p.m.) Review request for Build System and K

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 25, 2014, 5:02 p.m., David Faure wrote: > > kde-modules/KDEInstallDirs.cmake, line 340 > > > > > > I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what > > it's about. > > > >

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Aug. 25, 2014, 10:47 p.m.) Review request for Build System and K

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 25, 2014, 10:32 p.m., David Faure wrote: > > kde-modules/KDEInstallDirs.cmake, line 340 > > > > > > I'd name that ECM_INSTALL_PLUGINS_IN_QT_DIR to be clearer about what > > it's about. > > > >

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65234 --- kde-modules/KDEInstallDirs.cmake

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Aug. 25, 2014, 9:14 p.m.) Review request for Build System and KD

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 23, 2014, 1:16 a.m., David Faure wrote: > > Is this going to lead to "make install" installing plugins into $QTDIR > > rather than into $CMAKE_INSTALL_PREFIX? This is a big no-no by default. For > > a developer, the path returned by qmake might not even be writable > > (/usr/...). >

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65074 --- Is this going to lead to "make install" installing plugins int

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65037 --- Looks good. THere is a couple of things that is kind of a matt

Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- Review request for Build System and KDE Frameworks. Repository: extra-cma