Re: Review Request 119594: fix FileDialog size restorage

2014-09-05 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/ --- (Updated Sept. 5, 2014, 7:01 p.m.) Status -- This change has been ma

Re: Review Request 119594: fix FileDialog size restorage

2014-09-04 Thread Thomas Lübking
> On Aug. 4, 2014, 1 nachm., Lukáš Tinkl wrote: > > Great, this works for me :) Now what about > > https://git.reviewboard.kde.org/r/119593/ Sorry, I somehow missed this comment. https://git.reviewboard.kde.org/r/119593/ will make processing more robust - as long as the restore happens while

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
> On Aug. 4, 2014, 12:11 nachm., Martin Klapetek wrote: > > This does fix the issue here; +1 from me > > > > Also, are you investigating/reporting the bug to Qt devs? > > Thomas Lübking wrote: > On a quick glimpse, it looks like the issue is that QWidgetWindow syncs > stuff and that it syn

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63770 --- Ship it! Great, this works for me :) Now what about https://

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
> On Aug. 4, 2014, 12:11 nachm., Martin Klapetek wrote: > > This does fix the issue here; +1 from me > > > > Also, are you investigating/reporting the bug to Qt devs? On a quick glimpse, it looks like the issue is that QWidgetWindow syncs stuff and that it syncs (only) in ::event() ie. the eve

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63765 --- Ship it! This does fix the issue here; +1 from me Also, are

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
> On Aug. 3, 2014, 11:13 nachm., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (

Re: Review Request 119594: fix FileDialog size restorage

2014-08-04 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/ --- (Updated Aug. 4, 2014, 11:57 vorm.) Review request for KDE Frameworks, kd