Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-05 Thread Axel Rasmussen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119564/ --- (Updated Aug. 5, 2014, 7:07 a.m.) Status -- This change has been dis

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-05 Thread Kevin Funk
> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-04 Thread Alex Merry
> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-04 Thread Axel Rasmussen
> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-04 Thread Kevin Funk
> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. > > Sune Vuorela wr

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-04 Thread Sune Vuorela
> On Aug. 2, 2014, 9:04 a.m., Alex Merry wrote: > > I would rather change the code. The Qt behaviour was changed for a reason, > > to prevent accidental use of dangerous behaviour, and I'm not too keen on > > undoing that move for all software that uses KDECompilerSettings. agreed. - Sune

Re: Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-02 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119564/#review63665 --- I would rather change the code. The Qt behaviour was changed f

Review Request 119564: Add define to re-enable Qt functionality we depend on.

2014-08-01 Thread Axel Rasmussen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119564/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.