Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-08-01 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119540/ --- (Updated Aug. 1, 2014, 2:35 p.m.) Status -- This change has been mar

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-08-01 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119540/#review63630 --- Ship it! Ship It! - Lukáš Tinkl On Čec. 30, 2014, 2:32 dop

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-07-30 Thread Harald Sitter
> On Juli 30, 2014, 2:29 nachm., Luca Beltrame wrote: > > My question is, is KAuth being constructed with a default string ("") > > useful to anyone? IMO the issue, if any, it's there, and this looks like a > > workaround. (But I claim no expertise on the code, so feel free to flame me > > :P)

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-07-30 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119540/#review63509 --- My question is, is KAuth being constructed with a default stri

Review Request 119540: don't construct bogus KAuthAction objects

2014-07-29 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119540/ --- Review request for KDE Frameworks, Hrvoje Senjan and Martin Bříza. Reposi