Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- (Updated July 15, 2014, 10:21 p.m.) Status -- This change has been m

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-15 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/#review62401 --- Ship it! Ship It! - Milian Wolff On July 12, 2014, 9:41 a.

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Aleix Pol Gonzalez
> On July 12, 2014, 2:01 p.m., Aleix Pol Gonzalez wrote: > > tests/ksycocatest.cpp, line 104 > > > > > > Why does it need a static_cast if we're upcasting? > > Also constructing a shared pointer from the data

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
> On July 12, 2014, 2:01 p.m., Aleix Pol Gonzalez wrote: > > tests/ksycocatest.cpp, line 104 > > > > > > Why does it need a static_cast if we're upcasting? > > Also constructing a shared pointer from the data

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/#review62182 --- tests/ksycocatest.cpp

Review Request 119241: Fix QExplicitlySharedDataPointer usage

2014-07-12 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- Review request for KDE Frameworks. Repository: kservice Description ---