Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61923 --- Build is failing now when BUILD_EXAMPLES is turned on. - Mich

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated July 7, 2014, 7:28 p.m.) Status -- This change has been mar

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61766 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On July 1,

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated July 1, 2014, 8:23 p.m.) Review request for KDE Frameworks, Polk

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

> On July 1, 2014, 1:43 a.m., Aleix Pol Gonzalez wrote: > > core/CMakeLists.txt, line 24 > > > > > > Maybe we want to set an EXPORT_NAME? This way the user won't need a > > variable to link to the library. > >

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

> On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > core/CMakeLists.txt, line 24 > > > > > > Maybe we want to set an EXPORT_NAME? This way the user won't need a > > variable to link to the library. > >

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

> On July 1, 2014, 1:43 a.m., Aleix Pol Gonzalez wrote: > > core/CMakeLists.txt, line 24 > > > > > > Maybe we want to set an EXPORT_NAME? This way the user won't need a > > variable to link to the library. > >

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

> On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > PolkitQt-1Config.cmake.in, line 24 > > > > > > Passing the include dir is not needed anymore, given that those will be > > pulled by the targets. > >

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

> On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 6 > > > > > > Isn't it acceptable to depend on ECM here? not a wise choice. the master branch allows building both the Qt4 & Qt5 v

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

> On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote: > > agent/CMakeLists.txt, line 10 > > > > > > LINK_PUBLIC > On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote: > > core/CMakeLists.txt, line 13

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61334 --- CMakeLists.txt

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated June 30, 2014, 11:53 p.m.) Review request for KDE Frameworks, Po

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated June 30, 2014, 10:51 p.m.) Review request for KDE Frameworks, Po

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61326 --- agent/CMakeLists.txt

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated June 30, 2014, 10:28 p.m.) Review request for KDE Frameworks, Po

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61318 --- The pkgconfig files need to be changed as well. While changing

Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and Chri