Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Thomas Lübking
> On June 30, 2014, 9:01 a.m., Martin Gräßlin wrote: > > src/kwindowinfo_x11.cpp, line 301 > > > > > > are you sure it's Latin1? Normally string properties are utf8. > > Ivan Čukić wrote: > Well, since those

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/ --- (Updated June 30, 2014, 9:57 a.m.) Status -- This change has been ma

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/#review61264 --- This review has been submitted with commit 5c49d96ecd559c6180

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/#review61260 --- Ship it! Ship It! - Martin Gräßlin On June 30, 2014, 11:12

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
> On June 30, 2014, 9:01 a.m., Martin Gräßlin wrote: > > src/kwindowinfo_x11.cpp, line 301 > > > > > > are you sure it's Latin1? Normally string properties are utf8. Well, since those are UUIDs, it does not make

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/ --- (Updated June 30, 2014, 9:12 a.m.) Review request for KDE Frameworks, kwi

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/#review61256 --- src/kwindowinfo_x11.cpp

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

2014-06-30 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/ --- (Updated June 30, 2014, 8:22 a.m.) Review request for KDE Frameworks, kwi