Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/ --- (Updated June 22, 2014, 8:33 a.m.) Status -- This change has been ma

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60686 --- This review has been submitted with commit fdbcede38d1226b6dc

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-22 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60681 --- Ship it! Ship It! - Matthew Dawson On June 21, 2014, 5:37

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-21 Thread David Faure
> On June 17, 2014, 4:50 p.m., Matthew Dawson wrote: > > src/core/ksharedconfig.cpp, line 52 > > > > > > Why create a template function here, when the T must be > > GlobalSharedConfigList? Why not just put the l

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/ --- (Updated June 21, 2014, 9:37 a.m.) Review request for KDE Frameworks and

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-18 Thread Matthew Dawson
> On June 17, 2014, 12:50 p.m., Matthew Dawson wrote: > > src/core/ksharedconfig.cpp, line 52 > > > > > > Why create a template function here, when the T must be > > GlobalSharedConfigList? Why not just put the

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-18 Thread David Faure
> On June 17, 2014, 4:50 p.m., Matthew Dawson wrote: > > src/core/ksharedconfig.cpp, line 52 > > > > > > Why create a template function here, when the T must be > > GlobalSharedConfigList? Why not just put the l

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-17 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60298 --- LGTM. Just a couple of minor points, but if you prefer to get

Re: Review Request 118739: Make KSharedConfig thread-safe

2014-06-17 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60282 --- Ship it! Looks fine to me. - Kevin Ottens On June 14, 2014

Review Request 118739: Make KSharedConfig thread-safe

2014-06-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig