Re: Review Request 118614: Make KIO thread-safe

2014-06-18 Thread David Faure
> On June 17, 2014, 4:27 p.m., Thiago Macieira wrote: > > Since there was no problem in QtDBus after all, this patch can be reverted. Certainly not the whole patch, which brings in many other fixes. But yes, I've just reverted the QDBusConnection->KDBusConnectionPool changes. - David --

Re: Review Request 118614: Make KIO thread-safe

2014-06-17 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/#review60288 --- Since there was no problem in QtDBus after all, this patch can

Re: Review Request 118614: Make KIO thread-safe

2014-06-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/ --- (Updated June 14, 2014, 4:59 p.m.) Status -- This change has been ma

Re: Review Request 118614: Make KIO thread-safe

2014-06-14 Thread Thiago Macieira
> On June 8, 2014, 1:20 p.m., Thiago Macieira wrote: > > QDBusConnection is supposed to be threadsafe. > > David Faure wrote: > It's definitely not... > https://bugreports.qt-project.org/browse/QTBUG-39528 > > David Faure wrote: > Thiago, can we agree on using KDBusConnectionPool for n

Re: Review Request 118614: Make KIO thread-safe

2014-06-14 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/#review60077 --- Ship it! Would have never guessed it required so little adjus

Re: Review Request 118614: Make KIO thread-safe

2014-06-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/#review60074 --- Ship it! Despite my lack of knowledge on the code, it makes s

Re: Review Request 118614: Make KIO thread-safe

2014-06-14 Thread David Faure
> On June 8, 2014, 1:20 p.m., Thiago Macieira wrote: > > QDBusConnection is supposed to be threadsafe. > > David Faure wrote: > It's definitely not... > https://bugreports.qt-project.org/browse/QTBUG-39528 Thiago, can we agree on using KDBusConnectionPool for now, until the races describe

Re: Review Request 118614: Make KIO thread-safe

2014-06-08 Thread David Faure
> On June 8, 2014, 1:20 p.m., Thiago Macieira wrote: > > QDBusConnection is supposed to be threadsafe. It's definitely not... https://bugreports.qt-project.org/browse/QTBUG-39528 - David --- This is an automatically generated e-mail. To

Re: Review Request 118614: Make KIO thread-safe

2014-06-08 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/#review59565 --- QDBusConnection is supposed to be threadsafe. src/core/sched

Re: Review Request 118614: Make KIO thread-safe

2014-06-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/ --- (Updated June 8, 2014, 10:11 a.m.) Review request for KDE Frameworks, Ale