Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review80379 --- src/core/kconfig.cpp (line 98)

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59924 --- This review has been submitted with commit 69c203156d21385a8c

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59845 --- This review has been submitted with commit 988f09bb051dca0437

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- (Updated June 12, 2014, 5:11 a.m.) Status -- This change has been ma

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59828 --- Ship it! LGTM. The licence header has some extra whitespace.

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- (Updated June 11, 2014, 8:54 p.m.) Review request for KDE Frameworks and

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 7, 2014, 12:33 a.m., Matthew Dawson wrote: > > autotests/kconfigtest.cpp, line 930 > > > > > > Similarly, can you just change the config object's locale to something > > (en seems fine here) instead of

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- (Updated June 10, 2014, 8:42 a.m.) Review request for KDE Frameworks and

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 6, 2014, 12:21 p.m., John Layt wrote: > > src/core/kconfig.cpp, line 98 > > > > > > The bcp47Name() is a complicated beast that could add lots of other > > bits on like script to use, etc. I would stic

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59483 --- Ship it! Excellent, thanks! Just a couple minor things, then

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 6, 2014, 7:21 a.m., John Layt wrote: > > src/core/kconfig.cpp, line 98 > > > > > > The bcp47Name() is a complicated beast that could add lots of other > > bits on like script to use, etc. I would stick

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- (Updated June 6, 2014, 1:43 p.m.) Review request for KDE Frameworks and J

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

> On June 6, 2014, 1:37 p.m., Martin Gräßlin wrote: > > This change seems to break the KConfigTest::testMerge() well not really, it depends on the locale whether it breaks. If I switch to en it succeeds. - Martin --- This is an automat

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59416 --- This change seems to break the KConfigTest::testMerge() - Mar

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- (Updated June 6, 2014, 1:33 p.m.) Review request for KDE Frameworks and J

Re: Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/#review59415 --- src/core/kconfig.cpp

Review Request 118564: Fix locale-aware reading in KDesktopFile

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118564/ --- Review request for KDE Frameworks and John Layt. Repository: kconfig De