Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/ --- (Updated June 5, 2014, 9 a.m.) Status -- This change has been marked

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59288 --- This review has been submitted with commit 1074898877e87e078e

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59285 --- Ship it! Ship It! - Marco Martin On June 5, 2014, 8:23 a.m

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/ --- (Updated June 5, 2014, 8:23 a.m.) Review request for KDE Frameworks. Re

Re: Review Request 118547: Expose Formats as singleton

> On June 5, 2014, 3:44 a.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 40 > > > > > > Err no, this will fail when using formatRelativeDate and > > formatRelativeDateTime go

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59261 --- src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp

Re: Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59256 --- Ship it! Makes sense and looks nice! - Mark Gaiser On June

Review Request 118547: Expose Formats as singleton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative