Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated Aug. 5, 2014, 7:50 a.m.) Status -- This change has been mar

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review63815 --- Ship it! You dedice :) Thanks. autotests/kcolumnresizertest

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 7, 2014, 1:10 p.m., David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) > > Aurélien Gâteau wrote: > If you think this has a chance to get in, I can propose it. > > Aleix Pol Gonzalez wrote: > I think it would be accepted.

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On juin 7, 2014, 3:10 après-midi, David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) > > Aurélien Gâteau wrote: > If you think this has a chance to get in, I can propose it. > > Aleix Pol Gonzalez wrote: > I think it would be acce

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 7, 2014, 1:10 p.m., David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) > > Aurélien Gâteau wrote: > If you think this has a chance to get in, I can propose it. I think it would be accepted. I'm at Qt Contributor Summit anyway,

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 7, 2014, 3:10 p.m., David Faure wrote: > > Very nice. > > > > The question of "why not in Qt" hasn't been answered though :) If you think this has a chance to get in, I can propose it. - Aurélien --- This is an automatically

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59506 --- Very nice. The question of "why not in Qt" hasn't been answer

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 11:41 a.m., Dominik Haumann wrote: > > What about adding something like this to Qt ? > > Christoph Feck wrote: > First, I was thinking the same. The efforts with KF5 work was to get as > much features as possible into Qt, and only keep the stuff that isn't > accepted in

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated June 5, 2014, 2:38 p.m.) Review request for KDE Frameworks and C

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated June 4, 2014, 2:43 p.m.) Review request for KDE Frameworks and C

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 1:52 p.m., Christoph Feck wrote: > > src/kcolumnresizer.h, line 93 > > > > > > Does it make sense to make "= 0" the default value for the column? Sounds good to me. Just did so. - Aurélien

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 1:41 p.m., Dominik Haumann wrote: > > src/kcolumnresizer.cpp, line 200 > > > > > > You can use auto here, if wanted (you can use auto much more often in > > your patch, btw.): > > > >

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 12:01 p.m., David Edmundson wrote: > > src/kcolumnresizer.cpp, line 214 > > > > > > Do we really want it to be critical? > > > > Sometimes widgets are loaded dynamically, we probably d

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 11:41 a.m., Dominik Haumann wrote: > > What about adding something like this to Qt ? > > Christoph Feck wrote: > First, I was thinking the same. The efforts with KF5 work was to get as > much features as possible into Qt, and only keep the stuff that isn't > accepted in

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 1:52 p.m., Christoph Feck wrote: > > src/kcolumnresizer.cpp, line 182 > > > > > > What would be nice is if the widget you add is actually a GroupBox > > containing a supported layout, then it

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

> On June 4, 2014, 11:41 a.m., Dominik Haumann wrote: > > What about adding something like this to Qt ? First, I was thinking the same. The efforts with KF5 work was to get as much features as possible into Qt, and only keep the stuff that isn't accepted in our libraries. But here, I am not r

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59163 --- Regarding "remove" type functions, I agree we need them. Plea

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59170 --- What about adding something like this to Qt ? src/kcolumnres

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/#review59145 --- +++ src/kcolumnresizer.h

Re: Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- (Updated June 4, 2014, 11:52 a.m.) Review request for KDE Frameworks and

Review Request 118514: Add KColumnResizer to KWidgetsAddons

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118514/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget