Re: Review Request 118366: Porting keyboard module to Framework5

2016-10-21 Thread shivam makkar
> On Oct. 21, 2016, 11:12 a.m., Albert Astals Cid wrote: > > Seems this was somehow forgotten, sadly the patch does not apply anymore > > (or maybe it was commited and this was never closed?). > > > > Could you either upload a new patch if it's still needed or close the > > review if it is now

Re: Review Request 118366: Porting keyboard module to Framework5

2016-10-21 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated Oct. 21, 2016, 11:23 a.m.) Status -- This change has been d

Re: Review Request 118366: Porting keyboard module to Framework5

2016-10-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review100194 --- Seems this was somehow forgotten, sadly the patch does not a

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 23, 2014, 1:46 p.m.) Review request for kde-workspace, KDE

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60787 --- Can you please try to generate a proper diff? The one you uplo

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-20 Thread shivam makkar
> On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > kcms/keyboard/flags.cpp, line 21 > > > > > > remove? see the latest revision, apparently the diff is showing all the revisions made to the same file.

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-20 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 20, 2014, 9:24 p.m.) Review request for kde-workspace, KDE

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-20 Thread shivam makkar
> On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > > > > > for new connects I would use the new compile time checked syntax. > > shivam makkar wrote: > I tried

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-20 Thread Martin Gräßlin
> On May 28, 2014, 8:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > > > > > for new connects I would use the new compile time checked syntax. > > shivam makkar wrote: > I tried

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-19 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60569 --- kcms/keyboard/bindings.cpp

Re: Review Request 118366: Porting keyboard module to Framework5

2014-06-19 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 19, 2014, 6:48 p.m.) Review request for kde-workspace, KDE

Re: Review Request 118366: Porting keyboard module to Framework5

2014-05-31 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated May 31, 2014, 7:27 p.m.) Review request for kde-workspace, KDE F

Re: Review Request 118366: Porting keyboard module to Framework5

2014-05-29 Thread shivam makkar
> On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > > > > > for new connects I would use the new compile time checked syntax. I tried it but it was giving some error

Re: Review Request 118366: Porting keyboard module to Framework5

2014-05-29 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated May 29, 2014, 7:53 a.m.) Review request for kde-workspace, KDE F

Re: Review Request 118366: Porting keyboard module to Framework5

2014-05-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review58618 --- kcms/keyboard/flags.cpp

Re: Review Request 118366: Porting keyboard module to Framework5

2014-05-27 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated May 27, 2014, 9:02 p.m.) Review request for kde-workspace, KDE F

Review Request 118366: Porting keyboard module to Framework5

2014-05-27 Thread shivam makkar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- Review request for kde-workspace, KDE Frameworks and Andriy Rysin. Reposi