Re: Review Request 118111: adapt to ecm_add_tests

2014-05-13 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118111/ --- (Updated May 13, 2014, 2:24 p.m.) Status -- This change has been mar

Re: Review Request 118111: adapt to ecm_add_tests

2014-05-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118111/#review57876 --- This review has been submitted with commit 74bb2362037fe8e685

Re: Review Request 118111: adapt to ecm_add_tests

2014-05-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118111/#review57875 --- Ship it! Ship It! - Alex Merry On May 13, 2014, 11:52 a.m.

Re: Review Request 118111: adapt to ecm_add_tests

2014-05-13 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118111/ --- (Updated May 13, 2014, 11:52 a.m.) Review request for KDE Frameworks. R

Re: Review Request 118111: adapt to ecm_add_tests

2014-05-13 Thread Alexander Richardson
> On May 13, 2014, 12:44 p.m., Alex Merry wrote: > > autotests/CMakeLists.txt, line 16 > > > > > > Doesn't this macro now basically just do what ecm_add_tests does? Why > > not replace the single call to it with

Re: Review Request 118111: adapt to ecm_add_tests

2014-05-13 Thread Alex Merry
> On May 13, 2014, 10:44 a.m., Alex Merry wrote: > > autotests/CMakeLists.txt, line 16 > > > > > > Doesn't this macro now basically just do what ecm_add_tests does? Why > > not replace the single call to it with

Re: Review Request 118111: adapt to ecm_add_tests

2014-05-13 Thread Patrick von Reth
> On May 13, 2014, 10:44 a.m., Alex Merry wrote: > > autotests/CMakeLists.txt, line 16 > > > > > > Doesn't this macro now basically just do what ecm_add_tests does? Why > > not replace the single call to it with

Re: Review Request 118111: adapt to ecm_add_tests

2014-05-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118111/#review57858 --- autotests/CMakeLists.txt

Review Request 118111: adapt to ecm_add_tests

2014-05-13 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118111/ --- Review request for KDE Frameworks and kdewin. Repository: kdelibs4support