> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/
---
(Updated May 6, 2014, 8:08 p.m.)
Status
--
This change has been mark
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/#review57444
---
This review has been submitted with commit
a6672a99a2183a3ead
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 3:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 1:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
>
> Martin Gräßlin wrote:
> it's a SIC change as one could have used the variant specifying just
> NET::Properties and screen. This would now have to be changed to use
> NET::Properties2 before sc
> On May 6, 2014, 3:30 p.m., Kevin Ottens wrote:
> > AFAICT it is BIC but no SIC, no brainer.
it's a SIC change as one could have used the variant specifying just
NET::Properties and screen. This would now have to be changed to use
NET::Properties2 before screen argument.
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/#review57407
---
Ship it!
AFAICT it is BIC but no SIC, no brainer.
- Kevin Ot
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/#review57404
---
Looks good to me and I want to see it merged, but also an ACK
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118016/
---
Review request for KDE Frameworks and kwin.
Repository: kwindowsystem
D
17 matches
Mail list logo
