Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-04 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/ --- (Updated May 4, 2014, 2:11 p.m.) Status -- This change has been mark

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/#review57254 --- This review has been submitted with commit af49477a7237c51aff

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-04 Thread David Rosca
> On May 4, 2014, 12:53 p.m., David Faure wrote: > > Thanks! > > > > Anything else from options() that we're not handling? >From a quick look, FileDialogOption::DontConfirmOverwrite option is unhandled. This one is easy: dialog->m_fileWidget->setConfirmOverwrite(!options()->testOption(QFileDia

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/#review57244 --- Ship it! Thanks! Anything else from options() that we're not

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread David Rosca
> On May 3, 2014, 4:23 p.m., Mark Gaiser wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, line 157 > > > > > > No default? > > The Qt docs say that "AnyFile" is the default. > > http://qt-projec

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/ --- (Updated May 3, 2014, 4:38 p.m.) Review request for KDE Frameworks. Cha

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/#review57207 --- src/platformtheme/kdeplatformfiledialoghelper.cpp

Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des