Re: Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/ --- (Updated May 4, 2014, 4:57 p.m.) Status -- This change has been mark

Re: Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57259 --- This review has been submitted with commit 09d355975a6b9d3f89

Re: Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57241 --- Ship it! Ship It! - Alex Merry On May 3, 2014, 10:45 p.m.,

Re: Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/ --- (Updated May 3, 2014, 10:45 p.m.) Review request for Build System, Extra

Re: Review Request 117965: use the correct global variables

> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117965: use the correct global variables

> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/ --- (Updated May 3, 2014, 3:35 p.m.) Review request for Build System, Extra C

Re: Review Request 117965: use the correct global variables

> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57201 --- Ship it! Ship It! - Patrick von Reth On May 2, 2014, 10:53

Re: Review Request 117965: use the correct global variables

> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117965: use the correct global variables

> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? > > Patrick Spendrin wrote: > The

Re: Review Request 117965: use the correct global variables

> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > > > > > Now the comment doesn't match the code - which is correct? The fix here is that RUNTIME_OUTPUT_DI

Re: Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57180 --- kde-modules/KDECMakeSettings.cmake

Review Request 117965: use the correct global variables

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and