Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56631 --- This review has been submitted with commit fd6d554d8af7fe74d6

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56632 --- This review has been submitted with commit 7cd8252d2c662c6db4

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- (Updated April 26, 2014, 3:40 p.m.) Status -- This change has been m

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56633 --- This review has been submitted with commit 2fc7aeab836b0e4036

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56629 --- Ship it! Ship It! - Kevin Ottens On April 25, 2014, 7:18 p

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Alex Merry
> On April 26, 2014, 8:51 a.m., Stephen Kelly wrote: > > Would it be a good idea to start by reverting > > https://git.reviewboard.kde.org/r/116096/ ? > > Alex Merry wrote: > So we have no unit tests? I don't really see how that would help (except > in the strict sense of no unit tests =>

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Stephen Kelly
> On April 26, 2014, 8:51 a.m., Stephen Kelly wrote: > > Would it be a good idea to start by reverting > > https://git.reviewboard.kde.org/r/116096/ ? > > Alex Merry wrote: > So we have no unit tests? I don't really see how that would help (except > in the strict sense of no unit tests =>

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Alex Merry
> On April 26, 2014, 8:51 a.m., Stephen Kelly wrote: > > Would it be a good idea to start by reverting > > https://git.reviewboard.kde.org/r/116096/ ? So we have no unit tests? I don't really see how that would help (except in the strict sense of no unit tests => no failing unit tests). - Al

Re: Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-26 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/#review56594 --- Would it be a good idea to start by reverting https://git.rev

Review Request 117777: Make the KSelectionProxyModel unit test pass

2014-04-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/11/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kitemmod