Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-25 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/ --- (Updated April 25, 2014, 9:41 a.m.) Status -- This change has been m

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56498 --- This review has been submitted with commit 035c6fa9390ecb6642

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56436 --- Ship it! Ship It! - Kevin Ottens On April 21, 2014, 9:49 p

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56433 --- Ship it! Ship It! - David Faure On April 21, 2014, 9:49 p.

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-21 Thread Alex Merry
> On April 21, 2014, 9:42 p.m., David Faure wrote: > > Thank you so much. This was supposed to be on my todo list, but I had > > forgotten about it. And you did it much better than I would ever have done, > > with cmake-based unittests and all :-) > > > > +1 from me, giving a chance to Alex Ne

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/ --- (Updated April 21, 2014, 9:49 p.m.) Review request for Build System, Extr

Re: Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/#review56144 --- Thank you so much. This was supposed to be on my todo list, bu

Review Request 117619: Make ecm_setup_version interact well with CMP0048

2014-04-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117619/ --- Review request for Build System, Extra Cmake Modules and KDE Frameworks.