---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117582/
---
(Updated April 21, 2014, 5:07 p.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117582/#review56131
---
This review has been submitted with commit
5173dbb1e2deb445f9
> On April 21, 2014, 4:51 p.m., David Faure wrote:
> > Ah, OK. I like to make things easy and high-level to simplify maintenance,
> > but OK :)
In general, I agree, but my view is that this macro heads into the "dark magic"
area where it's very easy to screw it up, and this seems silly for som
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117582/#review56129
---
Ship it!
Ah, OK. I like to make things easy and high-level to
> On April 21, 2014, 3:12 p.m., David Faure wrote:
> > This macro was upstreamed into ECM as
> > modules/ECMDBusAddActivationService.cmake, why not port the code to that?
Because I want to remove that from ECM (or at least deprecate it), as I
consider it pointless. All it does is obfuscate two
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117582/#review56125
---
This macro was upstreamed into ECM as
modules/ECMDBusAddActiv
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117582/
---
Review request for KDE Frameworks.
Repository: kded
Description
---
