Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/ --- (Updated March 27, 2014, 7:41 p.m.) Status -- This change has been m

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/#review54363 --- This review has been submitted with commit 4758e47efc86c67a5b

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-27 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/#review54361 --- Ship it! Seems to work - Alexander Richardson On March 22,

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-27 Thread Kevin Ottens
> On March 22, 2014, 10:21 p.m., Nicolás Alvarez wrote: > > I can't test this because the kservice framework (dep of kinit) doesn't > > compile on Windows. > > Alex Merry wrote: > Yeah... I was operating on the basis of "this is probably less broken > than before". kwrapper_win.cpp also h

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-23 Thread Alexander Richardson
> On March 22, 2014, 11:21 p.m., Nicolás Alvarez wrote: > > I can't test this because the kservice framework (dep of kinit) doesn't > > compile on Windows. > > Alex Merry wrote: > Yeah... I was operating on the basis of "this is probably less broken > than before". kwrapper_win.cpp also h

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-23 Thread Alex Merry
> On March 22, 2014, 10:21 p.m., Nicolás Alvarez wrote: > > I can't test this because the kservice framework (dep of kinit) doesn't > > compile on Windows. Yeah... I was operating on the basis of "this is probably less broken than before". kwrapper_win.cpp also has some defunct stuff in it, I

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-22 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/#review53773 --- I can't test this because the kservice framework (dep of kinit

Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-22 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/ --- Review request for KDE Frameworks and Alexander Richardson. Repository: k