Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/#review52624 --- This review has been submitted with commit 8be89cb18293fce57b

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/ --- (Updated March 11, 2014, 10 a.m.) Status -- This change has been mar

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-11 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/#review52619 --- Ship it! I can reproduce the failure on ktexteditor with cmak

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aleix Pol Gonzalez
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
> On March 10, 2014, 3:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
> On March 10, 2014, 3:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/#review52565 --- Without this patch, the build also fails for me. With this pat

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aleix Pol Gonzalez
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Alex Merry
> On March 10, 2014, 2:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. > > Aurélien Gâteau wrote: > Just trie

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
> On March 10, 2014, 3:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? > > Aurélien Gâteau wrote: > Oh, version is in the request title. /me tests with 2.8. Just tried with 2.8.12, which is the lowes

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
> On March 10, 2014, 3:59 p.m., Aurélien Gâteau wrote: > > Strange, it works fine here. Which version of CMake are you using and which > > repository is failing? Oh, version is in the request title. /me tests with 2.8. - Aurélien --- T

Re: Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/#review52551 --- Strange, it works fine here. Which version of CMake are you us

Review Request 116696: Fix kservice_desktop_to_json when using cmake 2.8

2014-03-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116696/ --- Review request for KDE Frameworks. Repository: kservice Description ---